Sharing photos and creating photo albums in icloud means that other Apple users will see photos as long as this function is turned on?

If you mean Apple iCloud photo sharing, it's easy to create a shared album, just select the photos and videos you want to share from compatible devices, and then select the contacts you want to share with them. You can send an invitation to share an album to someone's email address or phone number through iMessage.