Photography does not make money. Should we give up photography?

If you can't make money through photography, whether to give up photography depends on your personal preference for photography. If you love photography very much, you can take photography as a hobby, as long as you don't invest too much to affect your quality of life. If you're not that interested and you really can't make money through photography, then focus on learning personal skills.